yangzhang75 commented on code in PR #8539:
URL: https://github.com/apache/texera/pull/8539#discussion_r4050554227
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
Review Comment:
Fixed. It was reading the accessor rather than calling it, so every export
from a cell carried the string "getWorkflowMetadata" as the workflow name.
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
Review Comment:
Done, `*ngIf` on the button. Specs cover both states.
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
Review Comment:
Added the guard and simplified the line to `[this.operatorId]`. Without an
operator there is no scope, so it now returns instead of opening a dialog that
would export nothing.
##########
frontend/src/app/workspace/component/result-exportation/result-exportation.component.ts:
##########
@@ -263,7 +275,8 @@ export class ResultExportationComponent implements OnInit {
this.inputFileName,
this.sourceTriggered === "menu",
destination,
- this.selectedComputingUnit
+ this.selectedComputingUnit,
+ this.operatorIds
Review Comment:
Done. The dialog now hands over the scope it resolved, so what is exported
is what it reported on.
##########
frontend/src/app/workspace/component/result-exportation/result-exportation.component.ts:
##########
@@ -81,9 +81,9 @@ import { NzIconDirective } from "ng-zorro-antd/icon";
],
})
export class ResultExportationComponent implements OnInit {
- /* Two sources can trigger this dialog, one from context-menu
- which only export highlighted operators
- and second is menu which wants to export all operators
+ /* Three sources can trigger this dialog: the context-menu, which exports
the highlighted
+ operators; the menu, which wants to export all of them; and a result cell,
which names the
+ one operator whose results it shows in operatorIds below and sends no
trigger of its own.
*/
sourceTriggered: string = inject(NZ_MODAL_DATA).sourceTriggered;
Review Comment:
Added. A result cell sends no trigger of its own, so it was undefined
through a field typed `string`.
##########
frontend/src/app/workspace/component/result-exportation/result-exportation.component.ts:
##########
Review Comment:
Done, `getAllOperatorIDs()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
