parshimers commented on code in PR #8542:
URL: https://github.com/apache/texera/pull/8542#discussion_r4007649199
##########
bin/k8s/templates/base/lakekeeper/lakekeeper-init-job.yaml:
##########
@@ -31,6 +31,48 @@ spec:
name: {{ .Release.Name }}-lakekeeper-init
spec:
restartPolicy: Never
+{{- if .Values.lakekeeperInit.createBucket }}
+ # Creates the Iceberg warehouse bucket before the warehouse is
registered.
+ # `rc` is RustFS's S3 client; using its image keeps the client out of the
+ # main container, which would otherwise have to fetch a binary at
runtime.
+ initContainers:
Review Comment:
I think it's because before on line 95, the MinIO client was being used
instead to do this. I think the idea of doing it like this separately is to
keep it outside of the lakekeeper-init container itself. I am not sure of the
wisdom of this idea, I would agree that @mengw15 's input would be good to have
if he is familiar with this area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
