mengw15 commented on code in PR #8542:
URL: https://github.com/apache/texera/pull/8542#discussion_r4007904755
##########
bin/k8s/templates/base/lakekeeper/lakekeeper-init-job.yaml:
##########
@@ -31,6 +31,48 @@ spec:
name: {{ .Release.Name }}-lakekeeper-init
spec:
restartPolicy: Never
+{{- if .Values.lakekeeperInit.createBucket }}
+ # Creates the Iceberg warehouse bucket before the warehouse is
registered.
+ # `rc` is RustFS's S3 client; using its image keeps the client out of the
+ # main container, which would otherwise have to fetch a binary at
runtime.
+ initContainers:
Review Comment:
Bucket creation isn't new — it was already Step 1 of this job, via a runtime
download of mc from dl.min.io; the bucket has to exist before Step 3, because
Lakekeeper validates the storage profile against it when the warehouse is
registered. I think the init container just swaps that runtime download for a
pinned client image (and waits for the store to be ready first), same as
compose's minio-init has always done. If this is tested and works, should be
fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
