mengw15 opened a new pull request, #8590: URL: https://github.com/apache/texera/pull/8590
### What changes were proposed in this PR? The warehouse picker (#8551) now sits beside the computing-unit picker, and the pair showed nothing but a name each. Fixes #8587. - **The trigger says what it is.** It gains the `deployment-unit` icon its own dashboard tab uses — the warehouse trigger already carries `cloud-server` — and its tooltip reads `Computing Unit: <name> (<status>)`: one tooltip on the control, instead of one on the badge and another on the name, carrying the name the trigger ellipsises at 220px and the status the badge can only show as a colour. - **With nothing selected, both the trigger and the run button name what is missing** — `Computing Unit`, as the warehouse side says `Warehouse` — instead of `Connect`, so the two pickers read the same way. The form view's run button follows, since it mirrors the canvas's disable conditions. - **That button was disabled in exactly the state it exists for.** The run button's guard ended in `selectedComputingUnit?.accessPrivilege !== Privilege.WRITE`; with no unit selected that compares against `undefined` and is always true, so the button offered to connect and refused every click, leaving `runWorkflow()`'s create-unit branch unreachable — the branch the form view's own comments describe as the canvas's click target, and which its test reaches only by calling the method directly. The privilege is now asked only of a unit that exists; a unit shared read-only still refuses to run. - **The badge stops claiming work that is not happening.** `computeStatus()` returned `"processing"` with nothing selected, which ant renders as a pulsing blue dot; it is now `"default"`. ### Any related issues, documentation, discussions? Closes #8587. Follows #8551 and #8589 (the warehouse side of the same pair). Part of #6870. ### How was this PR tested? - Vitest: new tests for the trigger's tooltip (long name, short name, nothing selected), for the no-unit button being clickable, and for a read-only unit still disabling it; the existing badge and label assertions updated. The workspace suite passes in full: 3325 tests. - Label width measured in a browser against the run button's clipping width (~106px for text): `Computing Unit` is 101px on macOS, 96px on Windows and Linux faces. - Failure paths verified rather than assumed: the privilege guard, the badge state, the tooltip and the label were each reverted on purpose and the suite confirmed to fail for the expected reason before being restored. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-5, claude-fable-5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
