mengw15 commented on code in PR #8590:
URL: https://github.com/apache/texera/pull/8590#discussion_r4044652458
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.spec.ts:
##########
@@ -1949,7 +1969,7 @@ describe("PowerButtonComponent", () => {
fixture.detectChanges();
const host = fixture.nativeElement as HTMLElement;
-
expect(host.querySelector(".connect-text")?.textContent).toContain("Connect");
+
expect(host.querySelector(".connect-text")?.textContent).toContain("Computing
Unit");
Review Comment:
Renamed — it now says it names the missing resource rather than quoting the
old label.
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.component.spec.ts:
##########
@@ -1503,7 +1503,7 @@ describe("WorkflowFormComponent", () => {
it("offers Connect before a unit is chosen", () => {
build(formViewWorkflow).ngOnInit();
- expect(component.runButtonState).toEqual({ label: "Connect", icon:
"plus-circle", disabled: true });
+ expect(component.runButtonState).toEqual({ label: "Computing Unit",
icon: "plus-circle", disabled: true });
Review Comment:
Renamed to match the label it asserts.
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.rendered.spec.ts:
##########
@@ -717,7 +717,7 @@ describe("WorkflowFormComponent (rendered template)", () =>
{
expect(el(".runbar .run")).not.toBeNull();
// Default state: no unit chosen, so the button reads Connect and is
disabled.
- expect(el(".runbar .run")?.textContent?.trim()).toContain("Connect");
+ expect(el(".runbar .run")?.textContent?.trim()).toContain("Computing
Unit");
Review Comment:
Comment updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
