mengw15 opened a new issue, #8591: URL: https://github.com/apache/texera/issues/8591
The warehouse gate added in #8551 reaches the form view only as a refusal, not as a state its run button shows. With the feature enabled and no warehouse selected, the canvas turns its run button into `Warehouse` and a click opens the create dialog. The form view's run button still reads `Run` and looks ready; clicking it starts nothing and surfaces "Create or select a warehouse before running." as a toast, because the guard lives in `ExecuteWorkflowService.sendExecutionRequest`'s callers rather than in the button's state. The execution is correctly blocked either way — this is about the button describing itself. `runButtonState` already enumerates the states a run cannot start from (invalid workflow, empty workflow, connecting, no computing unit, read-only unit) precisely so that, in its own words, "the reader is never sent to press a button that does nothing". The warehouse requirement is the one condition missing from that list. The picker itself is already there: the warehouse dropdown lives inside `ComputingUnitSelectionComponent`, which the form view embeds, so a warehouse can be picked or created without leaving the page. Adding a sixth case to `runButtonState` — `Warehouse`, disabled, the same shape as its no-computing-unit case — would be enough; `onRun()` needs no change, since it already returns early when the button is disabled. Part of #6870. Follows #8551. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
