PG1204 commented on issue #8728: URL: https://github.com/apache/texera/issues/8728#issuecomment-5862223997
hi @Ma77Ball & @xuang7 I wanted to clarify two things before I start this. 1. Which contract should be standardized on when a result attribute is empty? Today Spam and Sentiment `return null`, while Summarization and Iris throw. Repo-wide, only those two HF operators return `null` out of 61 operators implementing `getOutputSchemas`; 6 throw and 1 uses `require`. Since `getOutputSchemas` runs while an operator is still being configured, the choice depends on what the compiler does with each mid-edit, which I can't tell from the code. 2. Is it alright to change all four legacy HF operators in one PR, or would you rather I keep it to one and follow up separately? Either answer rewrites behavior that's already merged, so I'd rather follow your preference than pick one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
