parshimers opened a new pull request, #8812:
URL: https://github.com/apache/texera/pull/8812
Building the same commit twice now gives byte-identical release artifacts:
the source tarball, the Docker Compose bundle, the jars and dist zips, the
frontend bundle, and the container images. Before, each of them picked up the
build machine's clock, user, umask, or whatever the package archives held that
day, so a voter or downstream packager could not check a release against its
source.
| Artifact | What leaked in | Now |
| --- | --- | --- |
| Source tarball, compose bundle | builder uid/username, umask, file mtimes
(bundle changed every run) | `.github/scripts/create-release-tarballs.sh`:
sorted, 0:0, commit-time mtimes, `gzip -n`; the RC workflow and voters run the
tag's copy | | Jars, dist zips | native-packager stamps zip entries with the
wall clock | `SOURCE_DATE_EPOCH` passed to every `sbt dist` | | Frontend bundle
| build number from the wall clock; Sass `random(100)` | build number from
`SOURCE_DATE_EPOCH` (UTC); fixed `top: 50px` | | Web image yarn | repo's
`.yarnrc.yml` deleted, Yarn 4.5.1 swapped in, mutable install | the pinned Yarn
4.14.1 with `--immutable`, as in CI | | Base images | movable tags | pinned by
digest; Renovate's `dockerfile` manager bumps them weekly | | apt / pip in
images | live archives; unpinned transitive deps; dated logs and caches |
`bin/dockerfiles/snapshot/install.sh` installs as of 00:00 UTC on the commit's
day (snapshot.ubuntu.com / snapshot.debian.org, pip `--uploaded-prior-to`
) | | `/etc/shadow`, layer mtimes | build day; build time | commit day;
`rewrite-timestamp=true` | | `.git` in six runtime images | pack files, index,
refs | removed |
The day, not the commit time, keys the package snapshot so commits from the
same day still share cached apt/pip layers. The PyTorch index publishes no
upload times, so pip refuses a cutoff while it is in play; the helper installs
the one pin that needs it (`torch==2.13.0+cpu`, a local version PyPI cannot
host) exactly and without dependencies, then resolves everything else, torch's
dependencies included, from PyPI under the cutoff.
`.git` shipped only for `OPVersion`, which has looked up
`amber/src/main/scala/...` since the module moved to `common/workflow-operator`
in #3878. No commit ever touched that path, so every operator version has been
`"N/A"` in every deployment; it stays `"N/A"` without `.git`. The worker image
also dropped a fallback that, when the operator requirements failed to install,
silently shipped `wordcloud==1.9.2` and nothing else; such a build now fails.
Non-stable versions are replaced: play-json `3.1.0-M1` -> `3.0.6` (same
runtime dependencies; neither service imports it), RustFS `1.0.0-rc.6` ->
`1.0.0` (chart unchanged but for its version), and `alpine:latest`,
`nginx:alpine`, `curlimages/curl:latest` and `oven/bun:1-alpine` -> exact
versions. y-websocket-server gains a lockfile and `npm ci`.
`betterproto==2.0.0b7` stays: betterproto 2 has no stable release.
Closes #8809. Discussion: #8807.
`bin/README.md` documents what is pinned and how to rebuild an image; the
vote email gives voters the command that rebuilds both tarballs.
Each artifact was built twice from clean and compared byte for byte.
| Artifact | Result |
| --- | --- |
| Release tarballs | `bash .github/scripts/test_create_release_tarballs.sh`
(14 checks): identical across umask, clock, TZ, cwd and tag kind; the old
recipe differed run to run and leaked uid/username | | `amber` (212 MB) and
`config-service` dists | identical after two `sbt clean ... dist` runs with
`SOURCE_DATE_EPOCH` | | Frontend `dist/` (1,989 files) | identical across TZ,
umask and locale at a fixed path, as in the image (`/frontend`) | | Frontend
build number | `ng test --include src/build-version.spec.ts`: 24 pass, incl.
UTC, day boundaries and rejected malformed epochs | | `snapshot/install.sh` |
`bash bin/dockerfiles/snapshot/test_install.sh` (32 checks) | | jOOQ codegen |
223 files identical from two fresh databases | | play-json 3.0.6 |
`check_binary_deps.py jar` (strict) and NOTICE-binary regeneration pass for
both services | | Images, podman/buildah `--no-cache --timestamp` | identical:
mounter, agent-service, jupyter, config, access-control, file,
notebook-migration,
workflow-compiling, computing-unit-managing services | | Images, BuildKit
v0.33.1 `rewrite-timestamp=true` | identical: mounter, agent-service, jupyter |
| Computing-unit Python layers | apt + pip run twice: all 102,313 files
identical; torch resolves to `+cpu` |
The original mounter Dockerfile, rebuilt eight seconds apart with the same
flags, gave different images. Not verified end to end: the web-application,
computing-unit-master and -worker images, which exceed the test host's memory
and disk, and arm64. Their parts (bundle, dist, Python layers) are each covered
above.
Yes, Claude Opus 5.5
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well:
- `fix` is for behavior that worked before and no longer does; adding
or
removing a functionality, or reworking one so that user-facing
behavior
intentionally changes, is a `feat`; a change that leaves the
user-facing
behavior unchanged is a `refactor`.
- A test-only PR is `test(<module>): ...`; repairing a broken test is
`fix(test, <module>): ...`.
- A dependency bump is `fix(deps, <module>): ...` when it patches a CVE
and `chore(deps, <module>): ...` otherwise; GitHub Actions bumps take
`ci` as their module, e.g. `chore(deps, ci): ...`.
- A PR targeting a release branch appends the version as the last scope
component, e.g. `fix(deps, frontend, v1.2): ...`.
See CONTRIBUTING.md for the full convention.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if the
PR
is tested with existing test cases. Make sure to include/update test cases
that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please clarify
how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were not
added,
please describe why they were not added and/or why it was difficult to add.
-->
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
