xuang7 commented on code in PR #8813:
URL: https://github.com/apache/texera/pull/8813#discussion_r4171516067
##########
.github/workflows/create-release-candidate.yml:
##########
@@ -287,177 +270,59 @@ jobs:
name: rc-artifacts
path: |
${{ steps.vars.outputs.src_tarball }}
- ${{ steps.vars.outputs.src_tarball }}.asc
${{ steps.vars.outputs.src_tarball }}.sha512
${{ steps.vars.outputs.compose_tarball }}
- ${{ steps.vars.outputs.compose_tarball }}.asc
${{ steps.vars.outputs.compose_tarball }}.sha512
vote-email.txt
retention-days: 7
- upload-rc:
- runs-on: ubuntu-latest
- needs: create-rc
-
- steps:
- - name: Download RC artifacts
- uses: actions/download-artifact@v8
- with:
- name: rc-artifacts
-
- - name: Verify downloaded artifacts
- run: |
- SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
- COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-
- echo "Verifying downloaded artifacts..."
- ls -lh
-
- for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
- if [[ ! -f "$artifact" ]] || [[ ! -f "${artifact}.asc" ]] || [[ !
-f "${artifact}.sha512" ]]; then
- echo "Error: Missing artifact or signature/checksum for:
$artifact"
- exit 1
- fi
- done
-
- echo "✓ All artifacts downloaded successfully"
-
- - name: Install SVN
- run: |
- sudo apt-get update
- sudo apt-get install -y subversion
- svn --version
-
- - name: Checkout SVN dev directory
- run: |
- RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
- # Checkout the dev directory with depth=empty (lightweight)
- svn co --depth=empty
https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera \
- --username "${{ secrets.SVN_USERNAME }}" \
- --password "${{ secrets.SVN_PASSWORD }}" \
- --no-auth-cache
-
- cd svn-texera
-
- # Check if RC directory already exists on the remote
- SVN_BASE="https://dist.apache.org/repos/dist/dev/incubator/texera";
- if svn info "$SVN_BASE/$RC_DIR" >/dev/null 2>&1; then
- # Directory exists remotely — update (checkout) it into the
working copy
- svn update --depth=infinity "$RC_DIR" \
- --username "${{ secrets.SVN_USERNAME }}" \
- --password "${{ secrets.SVN_PASSWORD }}" \
- --no-auth-cache || true
- # If update didn't bring it down (empty parent checkout), do a
sparse checkout
- if [[ ! -d "$RC_DIR" ]]; then
- svn update --set-depth=infinity "$RC_DIR" \
- --username "${{ secrets.SVN_USERNAME }}" \
- --password "${{ secrets.SVN_PASSWORD }}" \
- --no-auth-cache
- fi
- echo "✓ RC directory already exists remotely, checked out: $RC_DIR"
- else
- # Directory doesn't exist remotely — create and add it
- mkdir -p "$RC_DIR"
- svn add "$RC_DIR"
- echo "✓ Created new RC directory: $RC_DIR"
- fi
-
- - name: Stage artifacts to SVN
+ - name: Generate release summary
run: |
- SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
- COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
- RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
-
- cd svn-texera/"$RC_DIR"
-
- # Copy all artifacts
- for artifact in "$SRC_TARBALL" "$COMPOSE_TARBALL"; do
- cp "$GITHUB_WORKSPACE/$artifact" .
- cp "$GITHUB_WORKSPACE/${artifact}.asc" .
- cp "$GITHUB_WORKSPACE/${artifact}.sha512" .
- done
-
- # Add files to SVN
- svn add * --force
-
- # Check status
- svn status
+ VERSION="${{ steps.vars.outputs.version }}"
+ RC_NUM="${{ steps.vars.outputs.rc_num }}"
+ TAG_NAME="${{ steps.vars.outputs.tag_name }}"
+ RC_DIR="${{ steps.vars.outputs.rc_dir }}"
+ COMMIT_HASH="${{ steps.vars.outputs.commit_hash }}"
+ SRC_TARBALL="${{ steps.vars.outputs.src_tarball }}"
+ COMPOSE_TARBALL="${{ steps.vars.outputs.compose_tarball }}"
- echo "✓ Staged all artifacts to SVN"
+ cat >> $GITHUB_STEP_SUMMARY <<EOF
+ ## Release Candidate Artifacts Built
- - name: Commit artifacts to dist/dev
- run: |
- VERSION="${{ needs.create-rc.outputs.version }}"
- RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
- RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
+ - **Version:** ${VERSION}
+ - **RC Number:** RC${RC_NUM}
+ - **Git Tag:** \`${TAG_NAME}\`
+ - **Commit:** \`${COMMIT_HASH}\`
- cd svn-texera
+ The artifacts are unsigned. Sign and stage them on your own machine:
- # Commit with descriptive message
- svn commit -m "Add Apache Texera ${VERSION} RC${RC_NUM} artifacts
(source + docker-compose)" \
- --username "${{ secrets.SVN_USERNAME }}" \
- --password "${{ secrets.SVN_PASSWORD }}" \
- --no-auth-cache
+ \`\`\`bash
+ # 1. Download and verify the checksums
+ gh run download ${{ github.run_id }} --repo ${{ github.repository }}
-n rc-artifacts -D rc
+ cd rc && sha512sum -c ${SRC_TARBALL}.sha512 ${COMPOSE_TARBALL}.sha512
- echo "✓ Committed artifacts to dist/dev/incubator/texera/$RC_DIR"
+ # 2. Sign with your own key
+ gpg --armor --detach-sign ${SRC_TARBALL}
+ gpg --armor --detach-sign ${COMPOSE_TARBALL}
- - name: Generate release summary
- run: |
- VERSION="${{ needs.create-rc.outputs.version }}"
- RC_NUM="${{ needs.create-rc.outputs.rc_num }}"
- TAG_NAME="${{ needs.create-rc.outputs.tag_name }}"
- RC_DIR="${{ needs.create-rc.outputs.rc_dir }}"
- COMMIT_HASH="${{ needs.create-rc.outputs.commit_hash }}"
- SRC_TARBALL="${{ needs.create-rc.outputs.src_tarball }}"
- COMPOSE_TARBALL="${{ needs.create-rc.outputs.compose_tarball }}"
-
- echo "## Release Candidate Created Successfully!" >>
$GITHUB_STEP_SUMMARY
- echo "" >> $GITHUB_STEP_SUMMARY
- echo "### Release Information" >> $GITHUB_STEP_SUMMARY
- echo "- **Version:** ${VERSION}" >> $GITHUB_STEP_SUMMARY
- echo "- **RC Number:** RC${RC_NUM}" >> $GITHUB_STEP_SUMMARY
- echo "- **Git Tag:** \`${TAG_NAME}\`" >> $GITHUB_STEP_SUMMARY
- echo "- **Commit:** \`${COMMIT_HASH}\`" >> $GITHUB_STEP_SUMMARY
- echo "" >> $GITHUB_STEP_SUMMARY
- echo "### Artifacts Location" >> $GITHUB_STEP_SUMMARY
- echo "**Staging Directory:**
https://dist.apache.org/repos/dist/dev/incubator/texera/${RC_DIR}/"; >>
$GITHUB_STEP_SUMMARY
- echo "" >> $GITHUB_STEP_SUMMARY
- echo "### Artifacts Created" >> $GITHUB_STEP_SUMMARY
- echo "| Artifact | Description |" >> $GITHUB_STEP_SUMMARY
- echo "|----------|-------------|" >> $GITHUB_STEP_SUMMARY
- echo "| \`${SRC_TARBALL}\` | Source code |" >> $GITHUB_STEP_SUMMARY
- echo "| \`${COMPOSE_TARBALL}\` | Docker Compose deployment bundle |"
>> $GITHUB_STEP_SUMMARY
- echo "" >> $GITHUB_STEP_SUMMARY
- echo "Each artifact has a corresponding \`.asc\` (GPG signature) and
\`.sha512\` (checksum) file." >> $GITHUB_STEP_SUMMARY
- echo "" >> $GITHUB_STEP_SUMMARY
- echo "### Next Steps" >> $GITHUB_STEP_SUMMARY
- echo "1. Build and push container images using the \`Build and push
images\` workflow with tag \`${VERSION}\`" >> $GITHUB_STEP_SUMMARY
- echo "2. Verify the artifacts at the staging directory" >>
$GITHUB_STEP_SUMMARY
- echo "3. Send [VOTE] email to [email protected]" >>
$GITHUB_STEP_SUMMARY
- echo "" >> $GITHUB_STEP_SUMMARY
- echo "### Verification" >> $GITHUB_STEP_SUMMARY
- echo "\`\`\`bash" >> $GITHUB_STEP_SUMMARY
- echo "# Import KEYS and verify signatures" >> $GITHUB_STEP_SUMMARY
- echo "gpg --import KEYS" >> $GITHUB_STEP_SUMMARY
- echo "gpg --verify ${SRC_TARBALL}.asc ${SRC_TARBALL}" >>
$GITHUB_STEP_SUMMARY
- echo "gpg --verify ${COMPOSE_TARBALL}.asc ${COMPOSE_TARBALL}" >>
$GITHUB_STEP_SUMMARY
- echo "" >> $GITHUB_STEP_SUMMARY
- echo "# Verify SHA512 checksums" >> $GITHUB_STEP_SUMMARY
- echo "sha512sum -c ${SRC_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
- echo "sha512sum -c ${COMPOSE_TARBALL}.sha512" >> $GITHUB_STEP_SUMMARY
- echo "\`\`\`" >> $GITHUB_STEP_SUMMARY
- echo "" >> $GITHUB_STEP_SUMMARY
- echo "**KEYS file:**
https://downloads.apache.org/incubator/texera/KEYS"; >> $GITHUB_STEP_SUMMARY
+ # 3. Commit to dist/dev with your ASF account
+ cd ..
+ svn co --depth=empty
https://dist.apache.org/repos/dist/dev/incubator/texera svn-texera
+ mkdir svn-texera/${RC_DIR}
+ cp rc/${SRC_TARBALL}* rc/${COMPOSE_TARBALL}* svn-texera/${RC_DIR}/
+ svn add svn-texera/${RC_DIR}
Review Comment:
Done in c696d412b. The runbook now checks with svn info and updates the
existing RC directory instead of creating it, and uses svn add --force so
re-staged files are picked up.
##########
.github/workflows/create-release-candidate.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Create and upload release candidate artifacts
+name: Create release candidate artifacts
Review Comment:
Agreed. This PR is from my fork, so the workflow can't be dispatched from
this branch. I'll test it through the release/v1.2 backport by using it to cut
1.2.1 RC2, which is safe now that it no longer signs or uploads, and link that
run here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
