Copilot commented on code in PR #8846:
URL: https://github.com/apache/texera/pull/8846#discussion_r4197194365
##########
frontend/src/app/workspace/component/ui-udf-parameters/ui-udf-parameters.component.html:
##########
@@ -37,8 +37,8 @@
<div class="ui-udf-parameter-row header">
<div
class="field-cell"
- *ngFor="let column of fieldColumns">
- <span class="col-title">{{ column.label }}</span>
+ *ngFor="let column of columns">
+ <span class="col-title">{{ columnLabel(column) }}</span>
Review Comment:
On a writer's Form View card with existing parameters, hiding Name leaves
the shared header as Value / Type, but Add parameter still renders three fixed
cells: empty / name input / type selector. The name input therefore appears
under Type and the type selector has no header. Hiding Value causes the same
mismatch. Give the draft its own fixed headers or independently labelled
layout, while preserving the filtered headers for existing rows. Add a template
regression test that opens the draft with Name or Value hidden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
