yangzhang75 commented on code in PR #8846:
URL: https://github.com/apache/texera/pull/8846#discussion_r4198789104
##########
frontend/src/app/workspace/component/ui-udf-parameters/ui-udf-parameters.component.html:
##########
@@ -37,8 +37,8 @@
<div class="ui-udf-parameter-row header">
<div
class="field-cell"
- *ngFor="let column of fieldColumns">
- <span class="col-title">{{ column.label }}</span>
+ *ngFor="let column of columns">
+ <span class="col-title">{{ columnLabel(column) }}</span>
Review Comment:
Good catch, fixed in 94aff482. While the draft row is open the table shows
its three fixed columns again, so the header, the draft row and the existing
rows line up whatever the author hid; the hide comes back when the draft
closes. That also covers the zero-row case, which took the same path before.
Added a template test that opens the draft with Type hidden and asserts three
headers and three cells in both the draft and the existing row, plus the
deletion check for the new guard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
