Xiao-zhen-Liu commented on code in PR #8771:
URL: https://github.com/apache/texera/pull/8771#discussion_r4286593718
##########
frontend/src/app/workspace/component/result-panel/error-frame/error-frame.component.ts:
##########
@@ -107,3 +108,16 @@ export class ErrorFrameComponent implements OnInit {
}, new Map<string, WorkflowFatalError[]>());
}
}
+
+/**
+ * The errors to show for one operator: its own errors, plus errors that are
not tied to any
+ * operator on the canvas. A Python UDF that fails while starting reports its
error from the
+ * coordinator ("unknown operator"), and the user looks for it by clicking
that UDF.
+ */
+export function errorsForOperator(
+ errors: readonly WorkflowFatalError[],
+ operatorId: string,
+ isOnCanvas: (id: string) => boolean
+): WorkflowFatalError[] {
+ return errors.filter(err => err.operatorId === operatorId ||
!isOnCanvas(err.operatorId));
Review Comment:
This branch predates #8668, which ties a failed start to the worker that
failed, so on main the UDF's startup error should already carry its own
operator id and show when the UDF is clicked. Could you merge main and check?
If so, this extra filter isn't needed; it would also show every error that
isn't tied to an operator under whichever operator the user clicks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
