aglinxinyuan commented on code in PR #9020: URL: https://github.com/apache/texera/pull/9020#discussion_r4310892504
########## bin/frontend-proto-gen.sh: ########## @@ -28,4 +28,8 @@ protoc --plugin="$GUI_DIR/node_modules/.bin/protoc-gen-ts_proto" \ -I="$PROTOBUF_DIR" \ "$WORKFLOW_PROTO" \ "$VIRTUALIDENTITY_PROTO" \ - --proto_path="$PROTOBUF_DIR" \ No newline at end of file + --proto_path="$PROTOBUF_DIR" + +# ts-proto also emits TypeScript for the imports used only for ScalaPB options +# (scalapb.proto and its descriptor.proto); nothing imports it, so drop it. +rm -rf "$GUI_PROTO_DIR/proto/scalapb" "$GUI_PROTO_DIR/proto/google" Review Comment: This change is debatable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
