aglinxinyuan opened a new pull request, #9028: URL: https://github.com/apache/texera/pull/9028
### What changes were proposed in this PR? Removes the `AmberConfig` object, whose only member, `masterNodeAddr`, is written but never read. **+8/−57 lines.** There is no behaviour change. - **`AmberConfig.scala`:** deleted. - **`AmberRuntime.scala`:** the two `AmberConfig.masterNodeAddr = createMasterAddress(...)` writes in `startActorMaster` / `startActorWorker`, the private `createMasterAddress` helper that only fed them, and the `Address` import. The seed nodes, hostname and actor system the two methods build are unchanged. - **`ScheduleGenerator.scala`:** a ScalaDoc line cited `AmberConfig.maxConcurrentRegions`; the value lives in `ApplicationConfig`. - **`AmberRuntimeSpec`:** drops the save/restore of the global, the sentinel, and the one case that only observed `masterNodeAddr`. Every case covering the surviving `AmberRuntime` behaviour stays. ### History | | | | --- | --- | | **Introduced by** | #811 (2020-08-22), "Merge Amber master into texera master": `masterNodeAddr`, for `ClusterListener` to tell the master node apart. #1439 (2022-02-12) added `createMasterAddress`, and #2245 (2023-12-06) moved the field into `AmberConfig` | | **Usage removed by** | #3029 (2024-12-08), "Create a separate web server for workflow execution". It deleted the last reader, `member.address != AmberConfig.masterNodeAddr` in `ClusterListener`. #3466 (2025-06-13) then moved every other `AmberConfig` member to `common/config`, leaving only this field | It has been write-only for nearly two years. ### Any related issues, documentation, discussions? Closes #9025 ### How was this PR tested? No new tests. `AmberRuntimeSpec` keeps its coverage of the master and worker startup paths. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile" "WorkflowExecutionService/scalafmtCheckAll" "WorkflowExecutionService/scalafixAll --check"`: success. - `sbt "WorkflowExecutionService/testOnly *AmberRuntimeSpec *ComputingUnitMasterSpec *ClusterListenerSpec *CostBasedScheduleGeneratorSpec"`: 4 suites, 68 tests, all pass. To re-check: ``` git grep -n -w -e AmberConfig -e masterNodeAddr -e createMasterAddress -- amber # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
