aglinxinyuan opened a new issue, #9025:
URL: https://github.com/apache/texera/issues/9025

   ### Task Summary
   
   `AmberConfig` 
(`amber/src/main/scala/org/apache/texera/amber/engine/common/AmberConfig.scala`)
 now holds a single member, `var masterNodeAddr: Address`. 
`AmberRuntime.startActorMaster` and `startActorWorker` write it through the 
private `createMasterAddress` helper, but nothing reads it.
   
   **Introduced by** #811 (2020-08-22, "Merge Amber master into texera 
master"), which added `masterNodeAddr` (then in `Constants`) for 
`ClusterListener` to tell the master node apart. `createMasterAddress` came 
with #1439 (2022-02-12), and #2245 (2023-12-06) moved the field into 
`AmberConfig`.
   
   **Usage removed by** #3029 (2024-12-08, "Create a separate web server for 
workflow execution"), which deleted the last reader, `member.address != 
AmberConfig.masterNodeAddr` in `ClusterListener`. #3466 (2025-06-13) later 
moved every other `AmberConfig` member to `common/config`, leaving only this 
field.
   
   Removing the object, the two writes and the helper is a pure deletion with 
no behaviour change.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to