zyratlo commented on code in PR #8910:
URL: https://github.com/apache/texera/pull/8910#discussion_r4330327678
##########
frontend/src/app/workspace/service/notebook-migration/migration-llm.ts:
##########
@@ -111,15 +111,66 @@ function toDerivedNotebook(cells: DerivedCell[]):
Notebook {
outputs: [],
execution_count: null,
})),
- metadata: {
- kernelspec: { display_name: "Python 3", language: "python", name:
"python3" },
- language_info: { name: "python" },
- },
+ metadata: structuredClone(metadata),
Review Comment:
No change needed. The frontend's browserslist (`defaults`, minus IE)
resolves to Chrome 109+, Firefox 140+, Edge 145+, Safari 26.3+ and iOS Safari
18.5+. `structuredClone` has been available in all of them since 2022 (Chrome
98, Firefox 94, Safari 15.4), so it cannot throw in any supported browser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
