carloea2 commented on code in PR #9054:
URL: https://github.com/apache/texera/pull/9054#discussion_r4331363630
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
@@ -135,9 +141,9 @@ export class ResultTableFrameComponent implements OnInit,
OnChanges {
) {}
ngOnChanges(changes: SimpleChanges): void {
- this.operatorId = changes.operatorId?.currentValue;
+ if (changes.operatorId) this.operatorId = changes.operatorId.currentValue;
if (this.operatorId) {
- const paginatedResultService =
this.workflowResultService.getPaginatedResultService(this.operatorId);
+ const paginatedResultService = this.paginatedResultService();
if (paginatedResultService) {
this.isFrontPagination = false;
Review Comment:
[P2] Clear the previous table when the selected port is empty. I reproduced
switching from a populated port 0 to an empty port 1: `setupResultTable`
returns on the empty page, leaving port 0 rows visible and loading stuck on.
The port-change path needs to clear the old table and finish loading for an
empty reply. Please add that transition to the regression tests.
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
@@ -395,7 +410,7 @@ export class ResultTableFrameComponent implements OnInit,
OnChanges {
if (!this.operatorId) {
return;
}
- const paginatedResultService =
this.workflowResultService.getPaginatedResultService(this.operatorId);
+ const paginatedResultService = this.paginatedResultService();
Review Comment:
[P2] Ignore replies from the output port no longer shown. I reproduced a
delayed page 1 reply from port 0 arriving after port 1 has loaded: it
overwrites port 1 with port 0 rows because the callback checks only
`pageIndex`. Cancel the previous request on a port change, or check the
operator and port identity before applying the reply. A delayed-response
regression catches this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
