kz930 commented on code in PR #9054:
URL: https://github.com/apache/texera/pull/9054#discussion_r4331494745
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
@@ -135,9 +141,9 @@ export class ResultTableFrameComponent implements OnInit,
OnChanges {
) {}
ngOnChanges(changes: SimpleChanges): void {
- this.operatorId = changes.operatorId?.currentValue;
+ if (changes.operatorId) this.operatorId = changes.operatorId.currentValue;
if (this.operatorId) {
- const paginatedResultService =
this.workflowResultService.getPaginatedResultService(this.operatorId);
+ const paginatedResultService = this.paginatedResultService();
if (paginatedResultService) {
this.isFrontPagination = false;
Review Comment:
Fixed in 13c129458: the table clears on a port change, and an empty reply
ends the loading. Covered by "clears the previous port's rows when the port
shown is empty".
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
@@ -395,7 +410,7 @@ export class ResultTableFrameComponent implements OnInit,
OnChanges {
if (!this.operatorId) {
return;
}
- const paginatedResultService =
this.workflowResultService.getPaginatedResultService(this.operatorId);
+ const paginatedResultService = this.paginatedResultService();
Review Comment:
Fixed in 13c129458: the reply is dropped unless its operator and port are
still the ones shown. Covered by "ignores a reply from a port that is no longer
shown".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
