zeshuai007 commented on a change in pull request #2148:
URL: https://github.com/apache/thrift/pull/2148#discussion_r429897851
##########
File path: lib/cpp/libthrift.vcxproj
##########
@@ -134,45 +182,53 @@
<ConfigurationType>StaticLibrary</ConfigurationType>
<UseDebugLibraries>true</UseDebugLibraries>
<CharacterSet>MultiByte</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review comment:
Dear @emmenlau , The previous project did not have it, it was generated
by visual studio when I confirm to chose the `v142 PlatformToolset`. Maybe the
correct way is to remove it and use what version of `PlatformToolset` is
depending on the developer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
