zeshuai007 commented on a change in pull request #2148:
URL: https://github.com/apache/thrift/pull/2148#discussion_r430127911
##########
File path: lib/cpp/libthrift.vcxproj
##########
@@ -134,45 +182,53 @@
<ConfigurationType>StaticLibrary</ConfigurationType>
<UseDebugLibraries>true</UseDebugLibraries>
<CharacterSet>MultiByte</CharacterSet>
+ <PlatformToolset>v142</PlatformToolset>
Review comment:
Dear @emmenlau , I am sorry for not clarify clearly. Visual Studio has
the config menu for choose the `PlatformToolset`. Developer can config the
correct `PlatformToolset` in they environment. Just like me, I config the `v142
PlatformToolset`, so it build correctly.But if i don't remove the config
informoation(`<PlatformToolset>v142</PlatformToolset>`) ,it may not work for
others who has the different `PlatformToolset`. So, I think remove it and
config by developer again maybe a better way.Even if they occur some problem
relate with this, Visual Studio also provide the output information that imply
them to config it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
