fishy commented on pull request #2351:
URL: https://github.com/apache/thrift/pull/2351#issuecomment-799724539


   > > how is this code being used by libfuzz, exactly?
   > 
   > cf 
https://github.com/google/oss-fuzz/pull/5264/files#diff-c54441e86b07048406afb5c7ed023b873669ff90d6b81613eedaaf4b90b7eb21R28
   > 
   > I think the trick you are looking for is `go mod edit -replace 
tutorial=./gen-go/tutorial`
   
   OK thanks.
   
   Can you add the newly added `lib/go/test/thriftfuzz` directory to our travis 
CI system (e.g. add it to 
https://github.com/apache/thrift/blob/62beb6751d3c70f8db8fed4a3bb76e4ff3765c22/lib/go/test/Makefile.am#L88
 rule)? Currently it's not checked by our CI system, so someone could 
accidentally break it (for example, make changes to `tutorial.thrift`) without 
realizing it.
   
   This this is actually a library, I guess you would need to write a test to 
actually use this library and fill in some fixed bytes. We can't really fuzz it 
in our travis CI, but we can at least make sure that it still compiles.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to