fishy commented on pull request #2351: URL: https://github.com/apache/thrift/pull/2351#issuecomment-802148093
> @fishy do you know what is missing in my Makefile.am ? > It seems target `all` is empty, but there is nothing to do if we do not build the tests... Oh you are right. We should still do all the `cd fuzz && go mod edit` under the `test` directory because that's where they are actually used. Sorry about my misleading suggestion. Actually I think if you just add a unit test under `test` directory to import from `fuzz`, we do not need to do all the `go mod edit` under `fuzz`. we either do them under `test` or not need to do them at all. The test itself passes means that the building of `fuzz` is working, so we do not need to build `fuzz`. But if you don't want to add and just want to make sure that the building of `fuzz` works, then what you are doing right now should work. I'm not super familiar with automake so I'm not sure how is it supposed to generate the `all` target from `Makefile.am`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
