Jimexist commented on PR #2553: URL: https://github.com/apache/thrift/pull/2553#issuecomment-1098621537
> > but a quick check shows it's defaults would change a lot of thrift code, and not always for the better. > > I'm not sure if the Thrift community would endorse its use, > > There were similar approaches a while ago and my (personal) feelings about automated C++ code formatting tools abilities are, well, let's call it "mixed feelings". But it's not only a C++ specific thing, I had the same experience with other tools and other languages as well. Sometimes the problems start with the style guide supplied by the manufacturer itself that ist a) the default and b) horribly broken. (Yes, I'm looking at you, Emba). > > The best tool I've seen in that regard is surely `gofmt`. The style actually makes sense to begin with, and it also offers not a single formatting-related option that could be configured. None. Zero. Kind of "get some sane style without the bikeshedding" approach. @Jens-G did you mean to comment on https://github.com/apache/thrift/pull/2559#pullrequestreview-938818662 instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
