Jimexist commented on PR #2553: URL: https://github.com/apache/thrift/pull/2553#issuecomment-1103395511
> However, if this is already an existing IDL language construct, then the name may already be established as "field annotations". > > @ctubbsii i created a simple example at https://gist.github.com/Jimexist/7acffaa0c4967193937a05f56098853b with the newly added flag in this pull request. > > Thanks. That example helps clear up some things. I was confused by the use of the terms "java" and "field annotation", because I was thinking [Java's Field `@Annotations`](https://docs.oracle.com/javase/8/docs/api/java/lang/reflect/Field.html#getAnnotation-java.lang.Class-). > > I would call these "tags" rather than "annotations", in order to reduce confusion. However, if this is already an existing IDL language construct, then the name may already be established as "field annotations". If that's the case, I can propose some slight wording improvements in the gen-java parameter help doc. I agree it's confusing but i guess that ship is sailed: the name in C++ and also in all of the file names it's named as "annotation". I guess the best method is to try best to make it less ambiguous in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
