ctubbsii commented on code in PR #2607:
URL: https://github.com/apache/thrift/pull/2607#discussion_r873250440
##########
compiler/cpp/src/thrift/generate/t_java_generator.cc:
##########
@@ -485,11 +484,6 @@ string t_java_generator::java_package() {
return "";
}
-string t_java_generator::java_suppressions() {
- return "@SuppressWarnings({\"cast\", \"rawtypes\", \"serial\",
\"unchecked\", \"unused\"})"
- + endl;
-}
Review Comment:
Some of these warnings should be fixed, though with better generated code.
Like... why are we generating a logger that is unused? Or why are we using raw
generics instead of the specific generic types when we know them? Or, why would
we need to suppress serial? Why not just use the generated serialUid or a 1-up
counter for custom Exceptions?
All this would take work, but eventually, we could probably get rid of these
warnings suppressions by improving the generator in other parts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
