fishy commented on PR #2469: URL: https://github.com/apache/thrift/pull/2469#issuecomment-1197476761
@GuangmingLuo none of the travis test passed, it doesn't look the compiler code compiles, so maybe fix that first? also in my previous comment I said that: >it would also be helpful (since the review on the spec/proposal part is mostly done) to paste the compiler generated go code into the pr so it's easier to review the code. and I don't see anyone pasting any generated validator go code into the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
