fishy commented on PR #2469: URL: https://github.com/apache/thrift/pull/2469#issuecomment-1205434127
>it could cause serialization /deserialization to fail. I thought that's the point :) But I think it's fine to make it manual checks only first then iterate on top of that later. But I think the function name `IsValid` implies that it would return a `bool` but it actually returns an `error`. `Validate() error` is probably a better name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
