kinoroy commented on code in PR #2670:
URL: https://github.com/apache/thrift/pull/2670#discussion_r976087219
##########
lib/swift/Sources/TProtocol.swift:
##########
@@ -41,7 +41,8 @@ public enum TType: Int32 {
case set = 14
case list = 15
case utf8 = 16
- case utf16 = 17
+ //case utf16 = 17
Review Comment:
Yes I think so, but java and kotlin have uuid set to 17 so I think it needs
to be more clearly documented which type should match to what integer. Because
right now neither utf16 nor uuid are documented types here:
https://thrift.apache.org/docs/idl.html
Some libraries have this utf16 = 17 (I think Python and Go) and some have
uuid = 17 (java, kotlin). So its hard to know what is correct. But without
matching the Java/Kotlin implementation the cross-tests won't pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
