kinoroy commented on code in PR #2670:
URL: https://github.com/apache/thrift/pull/2670#discussion_r976107840
##########
lib/swift/Sources/TProtocol.swift:
##########
@@ -132,12 +137,13 @@ public extension TProtocol {
func skip(type: TType) throws {
switch type {
case .bool: _ = try read() as Bool
- case .i8: _ = try read() as UInt8
+ case .i8: _ = try read() as Int8
Review Comment:
yeah I'm not sure if the spec changed at some point, but the docs now define
`i8` as an "An 8-bit signed integer" https://thrift.apache.org/docs/types so I
think it should be Int8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
