Jens-G commented on code in PR #2670:
URL: https://github.com/apache/thrift/pull/2670#discussion_r976340699
##########
lib/swift/Sources/TProtocol.swift:
##########
@@ -41,7 +41,8 @@ public enum TType: Int32 {
case set = 14
case list = 15
case utf8 = 16
- case utf16 = 17
+ //case utf16 = 17
Review Comment:
> utf16
Strings in Thrift ALWAYS go as UTF8 over the wire. Utf16 is not a valid
Thrift type, so adding it to TType seems odd.
> Because right now neither utf16 nor uuid are documented types here:
https://thrift.apache.org/docs/idl.html
Wrong link, this is release 0.17.0. The one at
https://github.com/apache/thrift/blob/master/doc/specs/idl.md is for master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
