Jens-G commented on code in PR #2670:
URL: https://github.com/apache/thrift/pull/2670#discussion_r980478983
##########
lib/swift/Sources/TProtocol.swift:
##########
@@ -132,12 +137,13 @@ public extension TProtocol {
func skip(type: TType) throws {
switch type {
case .bool: _ = try read() as Bool
- case .i8: _ = try read() as UInt8
+ case .i8: _ = try read() as Int8
Review Comment:
The `byte` type [was **always**
signed](https://thrift.apache.org/static/files/thrift-20070401.pdf), like all
Thrift integer types. So we renamed the type specifier a while ago from byte to
`i8` mostly to remove that constant source of confusion - a byte is considered
unsigned in many languages. Nevertheless, [for compatibility
reasons](https://www.mail-archive.com/[email protected]/msg50144.html) you
still can use `byte` in the IDL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
