Jimexist commented on code in PR #2686:
URL: https://github.com/apache/thrift/pull/2686#discussion_r989876500
##########
lib/java/gradle/sourceConfiguration.gradle:
##########
@@ -53,13 +53,6 @@ tasks.withType(JavaCompile).configureEach {
]
}
-tasks.withType(Javadoc) {
- failOnError false
- options.addStringOption('Xdoclint:none', '-quiet')
- options.addStringOption('encoding', 'UTF-8')
- options.addStringOption('charSet', 'UTF-8')
-}
-
Review Comment:
reverted
##########
lib/java/Makefile.am:
##########
@@ -23,7 +23,8 @@ all-local:
$(GRADLE) $(GRADLE_OPTS) assemble \
-Prelease=true \
-Pthrift.version=$(PACKAGE_VERSION) \
- --console=plain
+ --console=plain \
+ --stacktrace
Review Comment:
```suggestion
--console=plain
```
##########
build/docker/README.md:
##########
@@ -180,7 +180,7 @@ Last updated: October 1, 2017
| erlang | OTP-18 | OTP-23 | |
| go | 1.15.10 | 1.16.2 | |
| haxe | 3.2.1 | 3.4.4 | THRIFT-4352: avoid 3.4.2 |
-| java | 1.8.0\_191 | 11.0.3 | |
+| java | 1.8.0\_191 | 17 | |
Review Comment:
this column is for xenial but we have deprecated it recently...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
