Jimexist commented on code in PR #2710:
URL: https://github.com/apache/thrift/pull/2710#discussion_r995460759
##########
lib/java/src/main/java/org/apache/thrift/server/TSaslNonblockingServer.java:
##########
@@ -171,6 +171,7 @@ private void acceptNewConnection() {
LOGGER.warn("Failed to accept incoming connection.", e);
}
} else {
+ // TODO fix with try-with-resource for the return value of .channel
Review Comment:
let me revert this line - I don't think I can fully test whether the
selector resource _will_ leak. let me re-check later.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
