fishy commented on code in PR #2714:
URL: https://github.com/apache/thrift/pull/2714#discussion_r996150478
##########
compiler/cpp/src/thrift/thriftl.ll:
##########
@@ -248,6 +250,18 @@ literal_begin (['\"])
}
"&" { return tok_reference; }
+{uuidconstant} {
+ /* Placed before intconstant, because uuids start with either "{" or
directly with some hex digit */
+ yylval.uconst = strdup(yytext);
+ return tok_uuid_constant;
+}
+
+{guidconstant} {
+ yylval.uconst = strdup(&yytext[1]);
+ yylval.uconst[36] = '\000';
+ return tok_uuid_constant;
+}
Review Comment:
oh I see you stripped the curly braces from the token so language libraries
do not need to support the parsing of this form.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
