fishy commented on code in PR #2714:
URL: https://github.com/apache/thrift/pull/2714#discussion_r996141857
##########
test/ConstantsDemo.thrift:
##########
@@ -65,7 +65,9 @@ const map<i32,thing> GEN_WHAT = { 35 : { 'hello' : 325,
'goodbye' : 325352 } }
const set<i32> GEN_SET = [ 235, 235, 53235 ]
-const uuid GEN_UUID = "00000000-4444-CCCC-ffff-0123456789ab"
+// uuids are accepted with or without curly braces
+const uuid GEN_UUID = 00000000-4444-CCCC-ffff-0123456789ab
+const uuid GEN_GUID = {00112233-4455-6677-8899-aaBBccDDeeFF}
Review Comment:
1. can we force it still to be in string format? (e.g. adding leading and
trailing `"` to the ll file)
2. if we decided that we want to support the form with curly braces, then
I'll need to add support to that to the go library.
3. will the compiler still take this as a string token?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
