cfriedt commented on PR #2689:
URL: https://github.com/apache/thrift/pull/2689#issuecomment-1291953304
Currently seeing a bunch of MSVC errors like the one below:
```
C:\projects\thrift\lib\cpp\src\thrift/numeric_cast.h(47): warning C4003: not
enough arguments for function-like macro invocation 'max'
[C:\projects\build\MSVC2017\x64\lib\cpp\thrift.vcxproj]
C:\projects\thrift\lib\cpp\src\thrift/numeric_cast.h(50): warning C4003: not
enough arguments for function-like macro invocation 'max'
[C:\projects\build\MSVC2017\x64\lib\cpp\thrift.vcxproj]
ThreadManager.cpp
TimerManager.cpp
PeekProcessor.cpp
```
Will take a look shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]