cfriedt commented on PR #2689:
URL: https://github.com/apache/thrift/pull/2689#issuecomment-1323520474
> > We can fix it or revert it. Your decision.
> > BTW this also looks strange but don't know yet if it is related, may be
caused by another patch.
> > https://app.travis-ci.com/github/apache/thrift/jobs/589120685
>
> I've seen this before and it's due to header reordering. I've been careful
to avoid that FWIR.
>
> There is that one header that defines `THRIFT_IOCTL` etc macros and
because it does not itself include unistd, ioctl, fcntl, etc, it's ordering is
fragile.
Ah, this one is because `<thrift/config.h>` is not included
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
