tinloaf commented on PR #2755: URL: https://github.com/apache/thrift/pull/2755#issuecomment-1497001217
Thanks @Jens-G for triggering the CI builds again. I'm not sure whether I interpret the results, especially the failures, correctly: * the "Build / lib-go (1.19)" and "Build / lib-go (1.20)" runs fail/are cancelled. There is something about a missing `go.sum` file in the logs. I'll assume that this is not related to my change? * The "Build / cross-test" build is skipped, I assume as a result of lib-go not being built? * The AppVeyor build fails. That's the one where I'm not sure whether I am at fault. I see three failed builds, two of them with MSVC, one with MinGW. I do have MSVC on my machine, however I have been developing/building/testing Thrift under Linux via WSL1, using GCC and Clang. Maybe I need to set up an MSVC build. See below for details on the three failed builds. However, if I look at the AppVeyor builds of [the latest commit on the master branch](https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/46540784), it seems to me that these are the exact same three errors. So, I also assume that my changes have nothing to do with these errors. ## Failed AppVeyor Builds * For the first AppVeyor build, I don't see any error. These are the last lines in the log: ``` Building Custom Rule C:/projects/thrift/lib/cpp/test/CMakeLists.txt ProcessorTest.cpp EventLog.cpp ServerThread.cpp Generating Code... processor_test.vcxproj -> C:\projects\build\MSVC2017\x64\bin\Release\processor_test.exe Command exited with code 1 ``` This is weird. Usually, MSVC does print an error if it fails to compile / link something… * For the second build, the log is similar but warns about a library compatibility problem: ``` Building Custom Rule C:/projects/thrift/lib/cpp/test/CMakeLists.txt ProcessorTest.cpp EventLog.cpp ServerThread.cpp Generating Code... LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library [C:\projects\build\MSVC2015\x86\lib\cpp\test\processor_test.vcxproj] processor_test.vcxproj -> C:\projects\build\MSVC2015\x86\bin\Debug\processor_test.exe processor_test.vcxproj -> C:/projects/build/MSVC2015/x86/bin/Debug/processor_test.pdb (Full PDB) Command exited with code 1 ``` * The third build (the MinGW one) fails with undefined references to `boost::unit_test`. I'll just assume that this is not caused by my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
