tinloaf commented on PR #2755: URL: https://github.com/apache/thrift/pull/2755#issuecomment-1644047492
> I think the cross test failures should be fixed first if caused by this PR. The following cross-tests currently fail on the current **master** (see [here](https://github.com/apache/thrift/actions/runs/5574430848)): ``` (kotlin,swift) (kotlin,java,kotlin) (kotlin,go,rs) (swift,java,kotlin) (rs,swift) (java,swift) (rs,go,rs) (go,java,kotlin) (rs,java,kotlin) (java,go,rs) (java,java,kotlin) ``` The following cross-tests fail in this PR: ``` (java,go,rs) (java,swift) (kotlin,go,rs) (kotlin,swift) (go,java,kotlin) (rs,java,kotlin) (rs,go,rs) (rs,swift) (swift,java,kotlin) ``` If I'm not mistaken, the set of faling cross-tests in this PR is a subset of the failing cross-tests on master (which this PR was forked from). Also, none of these cross-tests involve C++, and I only made changes to the C++ generator. Both leads me to believe that my changes do not contribute to breaking all these cross-tests. I'm sorry, but I won't have the time (or the knowledge) to fix all these independently broken cross-tests. If that is a precondition for acceptance of this PR, I will have to abandon it (and just keep using a privately patched Thrift version). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
