fishy commented on code in PR #2779:
URL: https://github.com/apache/thrift/pull/2779#discussion_r1162166841
##########
.github/workflows/build.yml:
##########
@@ -137,14 +137,14 @@ jobs:
needs: compiler
runs-on: ubuntu-20.04
env:
- GRADLE_VERSION: "7.6"
+ GRADLE_VERSION: "8.0.2"
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
- java-version: 17
+ java-version: 19
Review Comment:
my main concern is that someone accidentally introduced some code that
requires feature not available in LTS versions, but if that's already
guaranteed by `-release` flag then I think this is fine.
the other concern is that the non-LTS versions all have a relatively much
shorter support lifespan so we need to update those to supported versions much
more frequently. For example, according to
https://www.oracle.com/java/technologies/java-se-support-roadmap.html 19 is no
longer supported?
##########
.github/workflows/build.yml:
##########
@@ -137,14 +137,14 @@ jobs:
needs: compiler
runs-on: ubuntu-20.04
env:
- GRADLE_VERSION: "7.6"
+ GRADLE_VERSION: "8.0.2"
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
- java-version: 17
+ java-version: 19
Review Comment:
my main concern is that someone accidentally introduced some code that
requires feature not available in LTS versions, but if that's already
guaranteed by `-release` flag then I think this is fine.
the other concern is that the non-LTS versions all have a relatively much
shorter support lifespan so we need to update those to supported versions much
more frequently. For example, according to
https://www.oracle.com/java/technologies/java-se-support-roadmap.html 19 is
already out of support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
