fishy commented on code in PR #2779:
URL: https://github.com/apache/thrift/pull/2779#discussion_r1163322147
##########
.github/workflows/build.yml:
##########
@@ -137,14 +137,14 @@ jobs:
needs: compiler
runs-on: ubuntu-20.04
env:
- GRADLE_VERSION: "7.6"
+ GRADLE_VERSION: "8.0.2"
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
- java-version: 17
+ java-version: 19
Review Comment:
out of support would also mean that it won't get security fixes, so if a
security bug is discovered in jdk 19 now the fix would only land on 20 and LTS
versions, not 19, I assume? But maybe Oracle's "sustaining support" means it
would still get security fixes?
if we are not using any new features introduced since 17 (the latest LTS
version right now), I'm not sure why do we _need to_ use java 19 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
