tinloaf commented on PR #2755: URL: https://github.com/apache/thrift/pull/2755#issuecomment-1774759219
Hi @emmenlau , thanks for reviving this. :) I just rebased and force-pushed. It seems that after the rebase, I cannot execute the `bin/UnitTests` executable locally anymore (and I think I could back in February?). The output I see is: ``` > ./bin/UnitTests Running 61 test cases... unknown location(0): fatal error: in "ToStringTest/locale_de_DE_floating_point_to_string": std::runtime_error: locale::facet::_S_create_c_locale name not valid ~/src/thrift/thrift/lib/cpp/test/ToStringTest.cpp(57): last checkpoint: "locale_de_DE_floating_point_to_string" test entry An error message from getaddrinfo on the console is expected: Thrift: Mon Oct 23 11:03:28 2023 getaddrinfo() -> -2; Name or service not known *** 1 failure is detected in the test module "thrift" ``` Looks like a locale is requested that my system does not have? This may be because I'm working in WSL, but I'm pretty sure it is not caused by my changes, which do not touch anything around locales. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
