tinloaf commented on PR #2755: URL: https://github.com/apache/thrift/pull/2755#issuecomment-1986017680
Hi @emmenlau @Jens-G any chance of getting this moving? It's been over a year now, and as I wrote multiple times already: This PR does not break any of the tests. All the tests reported as broken in this PR are broken because they are broken in `master` (or were broken when I last rebased). If I'm mistaken, please tell me which tests break because of this. We're using a Thrift version patched with this PR in production for over a year now, since it is otherwise impossible to build Thrift-generated code in C++20 mode, [as @bsergean confirmed](https://github.com/apache/thrift/pull/2755#issuecomment-1495967896). I will gladly rebase the changes one more time, but only if somebody actually takes a look at them then. Just spending the time of rebasing them every couple of months with zero effect seems kind of a waste. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
