fishy commented on code in PR #2883:
URL: https://github.com/apache/thrift/pull/2883#discussion_r1398003491
##########
lib/go/thrift/simple_server.go:
##########
@@ -211,6 +211,10 @@ func (p *TSimpleServer) innerAccept() (int32, error) {
select {
case <-ctx.Done():
// client exited, do nothing
+ if client != nil {
+ client.Close()
Review Comment:
can you explain more why do we need to close the client here? is there any
connection leak otherwise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
