jshen14 commented on code in PR #2883:
URL: https://github.com/apache/thrift/pull/2883#discussion_r1399529245
##########
lib/go/thrift/simple_server.go:
##########
@@ -356,6 +361,7 @@ func (p *TSimpleServer) processRequests(client TTransport)
(err error) {
ok, err := processor.Process(ctx, inputProtocol, outputProtocol)
if errors.Is(err, ErrAbandonRequest) {
err := client.Close()
+ client = nil
Review Comment:
Makes sense. Then is it good to have ```defer client.Close``` in
processRequests()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
