sveneld commented on code in PR #2935:
URL: https://github.com/apache/thrift/pull/2935#discussion_r1499984021
##########
.github/workflows/build.yml:
##########
@@ -91,6 +91,7 @@ jobs:
with:
php-version: ${{ matrix.php-version }}
extensions: mbstring, intl, xml
+ ini-values: "error_reporting=E_ALL"
Review Comment:
https://www.php.net/manual/en/errorfunc.configuration.php#ini.error-reporting
Prior to PHP 8.0.0, the default value was: E_ALL & ~E_NOTICE & ~E_STRICT &
~E_DEPRECATED. This means diagnostics of level E_NOTICE, E_STRICT and
E_DEPRECATED were not shown.
That's why we need to enable E_ALL in test to get all errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
