sveneld commented on code in PR #2935: URL: https://github.com/apache/thrift/pull/2935#discussion_r1499985562
########## lib/php/src/Thrift.php: ########## @@ -419,6 +420,7 @@ protected function _write($class, $spec, $output) * of PHP. Note that code is intentionally duplicated in here to avoid making * function calls for every field or member of a container.. */ +#[\AllowDynamicProperties] Review Comment: without this attribute we will get an error ``` 1) Test\Thrift\Unit\Lib\TExceptionTest::testExceptionWithSpecAndVals PHPUnit\Framework\Exception: PHP Deprecated: Creation of dynamic property Thrift\Exception\TException::$string is deprecated in /home/runner/work/thrift/thrift/lib/php/lib/Exception/TException.php on line 51 Deprecated: Creation of dynamic property Thrift\Exception\TException::$string is deprecated in /home/runner/work/thrift/thrift/lib/php/lib/Exception/TException.php on line 51 PHP Deprecated: Creation of dynamic property Thrift\Exception\TException::$int is deprecated in /home/runner/work/thrift/thrift/lib/php/lib/Exception/TException.php on line 51 Deprecated: Creation of dynamic property Thrift\Exception\TException::$int is deprecated in /home/runner/work/thrift/thrift/lib/php/lib/Exception/TException.php on line 51 PHP Deprecated: Creation of dynamic property Thrift\Exception\TException::$bool is deprecated in /home/runner/work/thrift/thrift/lib/php/lib/Exception/TException.php on line 51 Deprecated: Creation of dynamic property Thrift\Exception\TException::$bool is deprecated in /home/runner/work/thrift/thrift/lib/php/lib/Exception/TException.php on line 51 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
