sveneld commented on code in PR #2942:
URL: https://github.com/apache/thrift/pull/2942#discussion_r1510421036
##########
lib/php/lib/Transport/TCurlClient.php:
##########
@@ -227,7 +228,6 @@ public function flush()
register_shutdown_function(array('Thrift\\Transport\\TCurlClient',
'closeCurlHandle'));
self::$curlHandle = curl_init();
curl_setopt(self::$curlHandle, CURLOPT_RETURNTRANSFER, true);
- curl_setopt(self::$curlHandle, CURLOPT_BINARYTRANSFER, true);
Review Comment:
CURLOPT_BINARYTRANSFER This constant had no effect since PHP 5.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
