pkvach commented on code in PR #2942:
URL: https://github.com/apache/thrift/pull/2942#discussion_r1510776860
##########
build/docker/ubuntu-focal/Dockerfile:
##########
@@ -218,9 +218,15 @@ RUN apt-get install -y --no-install-recommends \
php-dev \
php-json \
php-pear \
+ php-mbstring \
+ php-xml \
+ php-curl \
re2c \
composer
+RUN pecl install xdebug-3.1.1 && \
+ echo "zend_extension=xdebug.so" > /etc/php/7.4/cli/conf.d/20-xdebug.ini
Review Comment:
Looks like there may be an issue here.
The Dockerfile installs PHP without specifying a version, so it will install
the latest version available in the package repository. However, the Xdebug
configuration is written to a specific PHP 7.4 directory. If the installed PHP
version is not 7.4, the Xdebug configuration will not be applied because PHP
won't be able to find it.
Same for other Dockerfiles as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
