pkvach commented on PR #2942: URL: https://github.com/apache/thrift/pull/2942#issuecomment-1981064719
@sveneld Regarding the falling `TPhpStreamTest` Looks like the issue is due to the fact that the `fopen` file resource created in the data provider is being closed before it can be used in the test. To fix this, I think we can move the creation of the file resource into the test method itself. I'm attaching an example solution with changes for `testOpen()` [TPhpStreamTest.php.zip](https://github.com/apache/thrift/files/14511560/TPhpStreamTest.php.zip) Maybe you'll have another option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
